[scribus-dev] Dear Oman team

[William Bader]

> From: cbradney at scribus.info
> Date: Sun, 1 Nov 2015 09:54:38 +0100
> To: scribus-dev at lists.scribus.net
> Subject: Re: [scribus-dev] Dear Oman team
> 
> 
> > On 01 Nov 2015, at 06:22, Khaled Hosny <khaledhosny at eglug.org> wrote:
> > 
> > On Sat, Oct 31, 2015 at 10:19:51AM -0500, Kunda Loves Scribus wrote:
> >> On Sat, Oct 31, 2015 at 8:44 AM, JLuc <jluc at no-log.org> wrote:
> >> 
> >>> Le 30/10/2015 21:53, Kunda Loves Scribus a écrit :
> >>> 
> >>>> Please trust that we're looking at you patches and testing them. There
> >>>> are only 2 active committing devs ATM and they
> >>>> volunteer their time.
> >>>> So in the mean time, feel free to work on other Scribus issues.
> >>>> 
> >>> 
> >>> I would like to add something about submitting patches :
> >>> 
> >>> Please test your patch carefully before submiting it.
> >>> 
> >>> Better : submit it to another student that will test it
> >>> and will provide you with its feedback : "it's ok" or "it's not ok",
> >>> so you can debug it in case it needs it.
> >>> 
> >>> Thanks a lot for your dedication,
> >>> JLuc
> >> 
> >> 
> >> I agree with JLuc, by doing this it saves precious volunteer time for
> >> anyone involved that works with the patch.
> > 
> > Do you have examples of untested patches being sent? AFAIK, all patches
> > are tested or otherwise how the contributor knows it fixed the issue. Or
> > may be I misunderstood the kind of testing needed?
> 
> 
> See my comments on bug #6230. Its not the only one. Its also not a big deal but it would be nice to know that someone else has a) reviewed the issue b) reviewed the patch and c) confirmed its fixed the issue. Like a buddy system, pair up contributors to add value.


In some projects, contributors sometimes send a note to the dev mailing list when they submit a completed patch, which allows anyone who knows how to build the application from source to test and make non-binding reviews, which can take some of the load off the committing developers.
Regards, William

 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scribus.net/pipermail/scribus-dev/attachments/20151101/35136f66/attachment.html>