<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'><br><br><div>> From: cbradney@scribus.info<br>> Date: Sun, 1 Nov 2015 09:54:38 +0100<br>> To: scribus-dev@lists.scribus.net<br>> Subject: Re: [scribus-dev] Dear Oman team<br>> <br>> <br>> > On 01 Nov 2015, at 06:22, Khaled Hosny <khaledhosny@eglug.org> wrote:<br>> > <br>> > On Sat, Oct 31, 2015 at 10:19:51AM -0500, Kunda Loves Scribus wrote:<br>> >> On Sat, Oct 31, 2015 at 8:44 AM, JLuc <jluc@no-log.org> wrote:<br>> >> <br>> >>> Le 30/10/2015 21:53, Kunda Loves Scribus a écrit :<br>> >>> <br>> >>>> Please trust that we're looking at you patches and testing them. There<br>> >>>> are only 2 active committing devs ATM and they<br>> >>>> volunteer their time.<br>> >>>> So in the mean time, feel free to work on other Scribus issues.<br>> >>>> <br>> >>> <br>> >>> I would like to add something about submitting patches :<br>> >>> <br>> >>> Please test your patch carefully before submiting it.<br>> >>> <br>> >>> Better : submit it to another student that will test it<br>> >>> and will provide you with its feedback : "it's ok" or "it's not ok",<br>> >>> so you can debug it in case it needs it.<br>> >>> <br>> >>> Thanks a lot for your dedication,<br>> >>> JLuc<br>> >> <br>> >> <br>> >> I agree with JLuc, by doing this it saves precious volunteer time for<br>> >> anyone involved that works with the patch.<br>> > <br>> > Do you have examples of untested patches being sent? AFAIK, all patches<br>> > are tested or otherwise how the contributor knows it fixed the issue. Or<br>> > may be I misunderstood the kind of testing needed?<br>> <br>> <br>> See my comments on bug #6230. Its not the only one. Its also not a big deal but it would be nice to know that someone else has a) reviewed the issue b) reviewed the patch and c) confirmed its fixed the issue. Like a buddy system, pair up contributors to add value.<br></div><div><br></div><div><br></div><div>In some projects, contributors sometimes send a note to the dev mailing list when they submit a completed patch, which allows anyone who knows how to build the application from source to test and make non-binding reviews, which can take some of the load off the committing developers.</div><div><br></div><div>Regards, William</div><div><br></div><div><br></div> </div></body>
</html>