[scribus-dev] patches are ready...

[gpittman at iglou.com]

On Mon, October 1, 2012 10:54, JLuc wrote:
> Le 28/09/2012 20:03, Craig Bradney a écrit :
>
>> All patches were submitted in the past for review, not for committing.
>> They need to be tested by
>> those who have time for testing.
>
> I've had problems in the past when trying to apply a patch
> (and i find it much easyer to compile and update a git or svn branch).
>
>
> It looks like there are different types of "diffs" files.
> Some cant be applied immediately, or need specific preparation steps.
> Maybe its a matter of choosing the right root directory when creating the
> diff. Maybe its a matter of option when creating the diff.
> Or maybe the matter is when applying the patch.
> And maybe some tools are better than other to create or apply .diff files,
>  or maybe some tools cannot be used to apply patches created with others
> tools.
>
> I wish some documentation and guidelines were created on how to create
> patches and how to apply them so as to easyen and widen that testing
> process.
>
I found the information on svn and patches was adequate for me, and worked
without problems. I was at a.l.e's workshop in LGM in Vienna which also
covered this, but have to say that by the time I got home I had forgotten
the specifics and looked them up in the subversion documentation.

I guess I would tend to line up with Craig about being conservative about
incorporating patches. It's one thing if a patch works, but one wants to
know if it risks or actually does break something else, and there has to
be a desire to keep some consistency in the way things are implemented in
the code. Non-committing users can help by testing out the patches then
giving feedback to the list about their experiences. Although I have
commit privileges, I don't feel comfortable assessing the quality of the
patches for actual incorporation. I'm mainly committing documentation
edits and updates.

Greg