[scribus-dev] Dear Oman team

[Kunda Loves Scribus]

On Sat, Oct 31, 2015 at 8:44 AM, JLuc <jluc at no-log.org> wrote:

> Le 30/10/2015 21:53, Kunda Loves Scribus a écrit :
>
>> Please trust that we're looking at you patches and testing them. There
>> are only 2 active committing devs ATM and they
>> volunteer their time.
>> So in the mean time, feel free to work on other Scribus issues.
>>
>
> I would like to add something about submitting patches :
>
> Please test your patch carefully before submiting it.
>
> Better : submit it to another student that will test it
> and will provide you with its feedback : "it's ok" or "it's not ok",
> so you can debug it in case it needs it.
>
> Thanks a lot for your dedication,
> JLuc


I agree with JLuc, by doing this it saves precious volunteer time for
anyone involved that works with the patch.  And... there is another option
for testing patches: Github.

Important note: For Scribus, Github serves officially _only_ as a mirror
for SVN ie. so no code commits happen on it but...

1) we have set up a Continuous Integration service on it (thanks to
volunteers, Khaled Hosny one of them) to build both Linux and MacOSX. So
whenever a PR requests is made travis-ci will build it and report results.
Think of it as a redundancy check

2) It also is easier to comment quickly on certain portions of a patch
(example: the MantisBugTracker team responding to a PR on their github
repo: https://github.com/mantisbt/mantisbt/pull/628/)

3) easy for testers to quickly trigger a build from the patch. For example:
ale recently submitted dawoodalbadi's latest patch for #6320 to github (
https://github.com/scribusproject/scribus/pull/32) with this purpose in
mind. I then was able to quickly craft a Homebrew formula that pulls the
patch in to it
https://gist.github.com/luzpaz/69c00f2a8516b5462614#file-scribuspatch-rb-L42-L45
so any OSX testers out there could easily run it.

Then once those stages are potentially fulfilled then the patch can be
submitted to the bugtracker in a more refined state.

Just another option to consider.

Cheer,
/Kunda
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scribus.net/pipermail/scribus-dev/attachments/20151031/2a65ae55/attachment.html>