[scribus-dev] After grouping [text|image] boxes one of them is missing lines/refresh

[Miss AL-Bahanta]

Hi,
I'm just assuming since the lines are drawn in Gray.The calculations error
that I'm taking about are in scribusdoc.cpp:15336
https://github.com/scribusproject/scribus/blob/master/scribus/scribusdoc.cpp#L15336
 when I added 1 to gh and gw the lines are drawn, so that made me think
there might be some rounding/calculation issue.
On the other hand, I noticed the group width and height are calculated more
than once.It calculations happens in
ScribusDoc::itemSelection_GroupObjects() and in Selection::setGroupRect()
which is called by Selection::getVisualGroupRect() in
ScribusDoc::itemSelection_GroupObjects().

Regards,
Asma

On 19 November 2015 at 14:00, ale rimoldi <ale.comp_06 at xox.ch> wrote:

> hey asma,
>
> On 19/11/15 09:25, Miss AL-Bahanta wrote:
>
>
> I'm trying to fix this issue http://bugs.scribus.net/view.php?id=13074.
> After reproducing this issue and going through the code, I'm assuming there
> is some rounding/calculations issues.I found the following piece of code
> which made think so.
> canvasmode.cpp:85
> m_pen["outline"]    = QPen(Qt::gray, 1.0 , Qt::SolidLine, Qt::FlatCap,
> Qt::MiterJoin);
> therefore, I think the textbox lines are drawn at the outlines of the
> group and that's why sometimes it's drawn in Gray or not drawn at all -
> correct me if I'm wrong. Thank you in advance :)
>
>
> do you mean that this line is drawn when other lines cannot be drawn?
>
> at which line do you spot a rounding issue?
>
> line 85 has no calculation...
>
> ciao
> a.l.e
>
> _______________________________________________
> scribus-dev mailing list
> scribus-dev at lists.scribus.net
> http://lists.scribus.net/mailman/listinfo/scribus-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scribus.net/pipermail/scribus-dev/attachments/20151119/601bac5e/attachment.html>