<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    Hi devs,
    <p> Thank you for your patience in reviewing my patches. I finished
      my work on interface for now. I want to start a new topic and deal
      with icons. I hope it is a good idea. I have some questions before
      I do anything.</p>
    <p>1st phase: Clean up and add missing icons<br>
    </p>
    <p>1) <span class="VIiyi" lang="en"><span class="JLqJ4b ChMk0b"
          data-language-for-alternatives="en"
          data-language-to-translate-into="hu" data-phrase-index="0"><span>I
            tried to assess the task</span></span></span>. I saw that
      there are missing icons and unnecessary icons too. I detected 178
      unnecessary icons and 192 missing icons. See the attached list.
      This is a very huge number. <span class="VIiyi" lang="en"><span
          class="JLqJ4b ChMk0b" data-language-for-alternatives="en"
          data-language-to-translate-into="hu" data-phrase-index="0"><span>Is
            it possible or am i doing something wrong?</span></span></span>
      If yes, I think I have to do a clean up first. Question: How to
      send to you a patch when it will contains PNG files deletion,
      (binary) addition and moving? I experienced before that usual git
      patches are <span class="kgnlhe" data-term-type="tl"
        role="button" tabindex="0" data-sl="en" data-tl="hu" dir="ltr">inappropriate</span><span
        class="MtFg0" data-term-type="sl" role="button" tabindex="0"
        data-sl="hu" data-tl="en" lang="hu"></span> for SVN.</p>
    <p>2) In scribus/scribus/undomanager.cpp UndoManager::initIcons()
      there is a set of icons, but it seems me that they are not used on
      Undo Manager interface. Is it a dead code or unfinished feature?
      That icons are completely missing from new 1_5_1/1_5_1_dark
      iconsets. What is the indention with these icons? S<span
        class="VIiyi" lang="en"><span class="JLqJ4b ChMk0b"
          data-language-for-alternatives="en"
          data-language-to-translate-into="hu" data-phrase-index="0"><span>hould
            they exist or be deleted?</span></span></span> </p>
    <p>3) In scribus/ui/autoformbuttongroup.cpp
      AutoformButtonGroup::getIconPixmap() I found that the affected
      icons should be live in two different size: 16×16 and 22×22. But
      the size 22×22 is completely missing from 1_5_1/1_5_1_dark
      iconsets. What is the indention here? S<span class="VIiyi"
        lang="en"><span class="JLqJ4b ChMk0b"
          data-language-for-alternatives="en"
          data-language-to-translate-into="hu" data-phrase-index="0"><span>hould
            they exist?</span></span></span></p>
    <p>4) In scribus/canvasmode.cpp  CanvasMode::modeCursor() there are
      custom cursors, but they are completely missing from
      1_5_1/1_5_1_dark iconsets. Is that a bug? What is the indention
      here? </p>
    <p>5) I noticed that new icons <span class="VIiyi" lang="en"><span
          class="JLqJ4b ChMk0b" data-language-for-alternatives="en"
          data-language-to-translate-into="hu" data-phrase-index="0"><span>sometimes</span></span></span>
      are only added to 1_5_1/1_5_1_dark iconsets. Is 1_5_0 deprecated?
      Or we want to keep it and add missing icons to old set too?<br>
    </p>
    <p>2nd phase: Tidy up<br>
    </p>
    <p>6) Why we use 22×22 size icons? The usual icons sizes are: 16×16,
      24×24, 32×32, 64×64... I suggest to move to 24×24.</p>
    <p>7) In every icon set there are icons in main directory and in 16
      and 22 and other directories. I suggest to move normal icons to
      directory 16, 24, 32... and leave only extra image (app logo,
      splash, etc) in the main directory. Can I <span class="VIiyi"
        lang="en"><span class="JLqJ4b ChMk0b"
          data-language-for-alternatives="en"
          data-language-to-translate-into="hu" data-phrase-index="0"><span>do
            that (moving icons and update the source code)? <br>
          </span></span></span></p>
    <p><span class="VIiyi" lang="en"><span class="JLqJ4b ChMk0b"
          data-language-for-alternatives="en"
          data-language-to-translate-into="hu" data-phrase-index="0"><span>8)
            There are very random names for the icons: German names,
            lowercase and uppercase, </span></span></span><span
        class="VIiyi" lang="en"><span class="JLqJ4b ChMk0b"
          data-language-for-alternatives="en"
          data-language-to-translate-into="hu" data-phrase-index="0"><span><span
              class="VIiyi" lang="en"><span class="JLqJ4b ChMk0b"
                data-language-for-alternatives="en"
                data-language-to-translate-into="hu"
                data-phrase-index="0"><span>hyphen and underscore</span></span></span>,
            etc... Can I rename icons? If yes, should I follow a naming
            convention like <a class="moz-txt-link-freetext"
              href="https://www.freedesktop.org/wiki/Specifications/icon-naming-spec/">https://www.freedesktop.org/wiki/Specifications/icon-naming-spec/</a>
            or not?</span></span></span></p>
    <p><span class="VIiyi" lang="en"><span class="JLqJ4b ChMk0b"
          data-language-for-alternatives="en"
          data-language-to-translate-into="hu" data-phrase-index="0"><span>9)
            Why we do not use Qt's icon resource files? <a
              class="moz-txt-link-freetext"
              href="https://doc.qt.io/qt-5/resources.html">https://doc.qt.io/qt-5/resources.html</a><br>
          </span></span></span></p>
    <p>10) In some .ui files
      (scribus/ui/propertywidget_textcolorbase.ui,
      scribus/ui/propertiespalette_textbase.ui) the icons are linked
      (<pixmap>../../resources/icons/zeichen.png</pixmap>
      but the links are broken) but usually the icons are loaded in .cpp
      codes. Why? If we use a Qt resource files can we add them in .ui
      files?<br>
      <span class="VIiyi" lang="en"><span class="JLqJ4b ChMk0b"
          data-language-for-alternatives="en"
          data-language-to-translate-into="hu" data-phrase-index="0"><span></span></span></span></p>
    <p><span class="VIiyi" lang="en"><span class="JLqJ4b ChMk0b"
          data-language-for-alternatives="en"
          data-language-to-translate-into="hu" data-phrase-index="0"><span>11)
            Can we use SVG icons (in 1_5_1 and dark) or we must use PNG
            icons?<br>
          </span></span></span> </p>
    12) It is not clear to me when we use 16×16 px icons and when
    22×22px icons. Is there any rule or is it completely random?
    <p>13) If one icon exist, it should be has both 16×16 and 22×22
      size? Or do we just need what we use?<br>
    </p>
    <p>14) Can we rename the icons sets to something more elegant: 1_5_0
      -> "classic"; 1_5_1 -> "markon", "flat" or something else?</p>
    <p>For now I want to deal with 1st phase only.<br>
    </p>
    <p>Gellért<br>
    </p>
    <span class="VIiyi" lang="en"><span class="JLqJ4b ChMk0b"
        data-language-for-alternatives="en"
        data-language-to-translate-into="hu" data-phrase-index="0"><span></span></span></span>
    <p><br>
    </p>
    <pre class="moz-signature" cols="72">-- 
Gyuris Gellért
H-6724 Szeged, Rigó u. 16/A TT8 
+3630 3808472 <a class="moz-txt-link-abbreviated" href="mailto:bubu@ujevangelizacio.hu">bubu@ujevangelizacio.hu</a>
<a class="moz-txt-link-freetext" href="https://bubu.ujevangelizacio.hu">https://bubu.ujevangelizacio.hu</a>
</pre>
  </body>
</html>