<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br class=""><blockquote type="cite" class="">On 22 Mar 2016, at 20:23, Khaled Hosny <<a href="mailto:khaledhosny@eglug.org" class="">khaledhosny@eglug.org</a>> wrote:<br class=""><br class="">On Tue, Mar 22, 2016 at 07:36:08PM +0100, Craig Bradney wrote:<br class=""><blockquote type="cite" class=""><blockquote type="cite" class=""><blockquote type="cite" class=""><br class="">Some rendering comparisons:<br class=""><br class="">We need to do this side by side comparison of trunk vs host/boxes.<br class="">3 issues to note at first:<br class="">- character positioning is higher in the frame in boxes<br class="">- Not as many characters fit in the frames in boxes<br class=""></blockquote><br class="">We couldn’t see such differences in the file you sent, see the diff<br class="">images in Dawood’s reply.<br class=""></blockquote><br class="">At lower zoom levels I can see them, at higher ones, no. <br class=""></blockquote><br class="">I can check again, but if it depends on zoom level so it might be<br class="">related to the different font rasterisation strategy we are using.<br class=""></blockquote><div class=""><br class=""></div><div class=""><img apple-inline="yes" id="FC7D6E6F-5E0A-4FFC-983C-227AC249E136" height="147" width="1600" apple-width="yes" apple-height="yes" src="cid:8452DB57-D80B-48A9-910D-F300FAC7B7D5@lux.bradney.info" class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">You can see it there. Host on is the left.</div><div class=""><br class=""></div><br class=""><blockquote type="cite" class=""><br class=""><blockquote type="cite" class=""><blockquote type="cite" class=""><br class=""><blockquote type="cite" class="">- The right aligned paragraphs have the top line missing a character/aren’t aligned<br class=""></blockquote><br class="">It was indeed that the last glyph in the line was always remove, should<br class="">be fixed now.<br class=""></blockquote><br class="">Now thats better.<br class=""><br class="">We need some more complex tests apart from the file I created. Ideas<br class="">on how we can do this?<br class=""></blockquote><br class="">We have a collection of files we use for testing here, not complex but<br class="">they try to test different features. I’ll try to collect and send them.<br class=""><br class=""><blockquote type="cite" class="">Also, what about any ideas on rendering speed comparisons?<br class=""></blockquote><br class="">I have no idea how to measure that, but I worked on optimizing the rendering<br class="">(after profiling was callgrind) fearing that ours was too slow, to<br class="">discover that we are actually feel much faster than trunk (text<br class="">selection, for example is snappier and does not lag behind as the cursor<br class="">moves).<br class=""><br class="">Currently (on my HiDPI machine) most of the rendering time (~30% of the<br class="">all application profile) is spent in QPainter::drawPixmap(). I believe<br class="">rewriting ScPainter on top of QPainter can make it much faster, instead<br class="">of the current code which redraws the whole canvas as a pixmap on each<br class="">draw event. But that is a small project of its own.<br class=""></blockquote><br class=""><div class=""><br class=""></div><div class="">You’re correct. cursor movement is a lost faster with Host.</div><div class=""><br class=""></div><div class="">I’m very tempted to say let’s import this.. but honestly, scared to go through the experience with marks/bullets/numbering. Dev disappears and we don’t know the code. </div><div class=""><br class=""></div><div class="">Unfortunately I need Jean to review it too and he is travelling. He will likely be reading this though and he is back at the end of the week.</div><div class=""><br class=""></div><div class="">Can you send me the patch (or instructions on how to create it myself) and I can test on another svn tree I have for this?</div><div class=""><br class=""></div><div class="">thanks</div><div class="">Craig</div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div></body></html>