<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
hey as.<br>
<br>
<blockquote
cite="mid:CAPKqcuSaQg49t=vjhw86TwK6vr7R5b8qHf9Fy4wNF1ooBW_8Sw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div>
<div>Actually, I commented this line before and it solves
the issue. So I'm asking why calling p->scale ()<br>
</div>
where it will scale by 1 which does nothing and it changes
the zoom_factor to 1.I'm assuming that the issue might be in
the modified zoom_factor.<br>
</div>
</div>
</div>
</blockquote>
<br>
this line of code arises a few questions:<br>
<br>
- why is "double groupWidth" defined in pageitem.h and not in
pageitem_group.h?<br>
- what is the difference between m_width and groupWidth?<br>
- why does width have a m_ prefix and groupWidth does not have it?<br>
<br>
<br>
but the main question is about the difference between groupWdith and
m_width.<br>
<br>
i suggest you (and the other guys) that as a first step for finding
out what this line of code does and why it has been written, you
should write a short doxygen doc for the groupWidth and groupHeight
variables and submit that patch.<br>
<br>
<br>
<br>
just a reference, if you look further down in pageitem.h you see:<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
double oldXpos; ///< Stores the old X-position for undo action.
Is used to detect move actions.<br>
<br>
that's an example of doxygen doc.<br>
<br>
<br>
is not in my eyes a perfect doxygen comment:<br>
<br>
double oldXpos; ///< used for detecting move actions .<br>
<br>
would probably have been better, since the name of the class member
variables already says that it's an old x position... we should try
to keep them as short as possible and only document what we could
not write in the name itself.<br>
<br>
<br>
one last remark: before submitting a new doxygen doc, please discuss
internally if it's the shortest text you can come up! :-)<br>
<br>
<br>
hth<br>
a.l.e<br>
</body>
</html>