[scribus-dev] Icon sets, missing icons

Tue Mar 16 20:53:31 UTC 2021

Hi Gellert

For this icon work of cleaning up SVN I recommend we wait until after 1.5.7 is released. Let’s get all your current work sorted, then we release 1.5.7.

You can just send us a list of files to remove. Note we will probably move them to an “old” directory. 
Note on the structure of iconset folders: what are in 16/22/32 etc directories were a set of icons we started to build and designers created/added to. Old icons were left in the base directories as some were still used. 
Scribus “falls back” to old icon sets if it cannot find icons in the current sets, thereby reducing the impact of a new set being created but missing an icon. 
22x22 is historical and we should use standard sizes. 22x22 might just have been what worked best with the UI elements of the time. 
We can certainly rename whatever we want - a lot of Scribus was in German from the beginning. We’ve renamed a lot now but not all.
I’m not sure I see a reason to use Qt’s resource files - we stopped using Qt’s build related system years ago.

thanks
Craig

> On 13 Mar 2021, at 12:59 pm, Gyuris Gellért <jobel at ujevangelizacio.hu> wrote:
> 
> Hi devs,
> Thank you for your patience in reviewing my patches. I finished my work on interface for now. I want to start a new topic and deal with icons. I hope it is a good idea. I have some questions before I do anything.
> 
> 1st phase: Clean up and add missing icons
> 
> 1) I tried to assess the task. I saw that there are missing icons and unnecessary icons too. I detected 178 unnecessary icons and 192 missing icons. See the attached list. This is a very huge number. Is it possible or am i doing something wrong? If yes, I think I have to do a clean up first. Question: How to send to you a patch when it will contains PNG files deletion, (binary) addition and moving? I experienced before that usual git patches are inappropriate for SVN.
> 
> 2) In scribus/scribus/undomanager.cpp UndoManager::initIcons() there is a set of icons, but it seems me that they are not used on Undo Manager interface. Is it a dead code or unfinished feature? That icons are completely missing from new 1_5_1/1_5_1_dark iconsets. What is the indention with these icons? Should they exist or be deleted?
> 
> 3) In scribus/ui/autoformbuttongroup.cpp AutoformButtonGroup::getIconPixmap() I found that the affected icons should be live in two different size: 16×16 and 22×22. But the size 22×22 is completely missing from 1_5_1/1_5_1_dark iconsets. What is the indention here? Should they exist?
> 
> 4) In scribus/canvasmode.cpp  CanvasMode::modeCursor() there are custom cursors, but they are completely missing from 1_5_1/1_5_1_dark iconsets. Is that a bug? What is the indention here?
> 
> 5) I noticed that new icons sometimes are only added to 1_5_1/1_5_1_dark iconsets. Is 1_5_0 deprecated? Or we want to keep it and add missing icons to old set too?
> 
> 2nd phase: Tidy up
> 
> 6) Why we use 22×22 size icons? The usual icons sizes are: 16×16, 24×24, 32×32, 64×64... I suggest to move to 24×24.
> 
> 7) In every icon set there are icons in main directory and in 16 and 22 and other directories. I suggest to move normal icons to directory 16, 24, 32... and leave only extra image (app logo, splash, etc) in the main directory. Can I do that (moving icons and update the source code)? 
> 
> 8) There are very random names for the icons: German names, lowercase and uppercase, hyphen and underscore, etc... Can I rename icons? If yes, should I follow a naming convention like https://www.freedesktop.org/wiki/Specifications/icon-naming-spec/ <https://www.freedesktop.org/wiki/Specifications/icon-naming-spec/> or not?
> 
> 9) Why we do not use Qt's icon resource files? https://doc.qt.io/qt-5/resources.html <https://doc.qt.io/qt-5/resources.html>
> 10) In some .ui files (scribus/ui/propertywidget_textcolorbase.ui, scribus/ui/propertiespalette_textbase.ui) the icons are linked (<pixmap>../../resources/icons/zeichen.png</pixmap> but the links are broken) but usually the icons are loaded in .cpp codes. Why? If we use a Qt resource files can we add them in .ui files?
> 
> 11) Can we use SVG icons (in 1_5_1 and dark) or we must use PNG icons?
> 
> 12) It is not clear to me when we use 16×16 px icons and when 22×22px icons. Is there any rule or is it completely random?
> 13) If one icon exist, it should be has both 16×16 and 22×22 size? Or do we just need what we use?
> 
> 14) Can we rename the icons sets to something more elegant: 1_5_0 -> "classic"; 1_5_1 -> "markon", "flat" or something else?
> 
> For now I want to deal with 1st phase only.
> 
> Gellért
> 
> 
> 
> -- 
> Gyuris Gellért
> H-6724 Szeged, Rigó u. 16/A TT8 
> +3630 3808472 bubu at ujevangelizacio.hu <mailto:bubu at ujevangelizacio.hu>
> https://bubu.ujevangelizacio.hu <https://bubu.ujevangelizacio.hu/>
> <Scribus icons.ods>_______________________________________________
> scribus-dev mailing list
> scribus-dev at lists.scribus.net
> http://lists.scribus.net/mailman/listinfo/scribus-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scribus.net/pipermail/scribus-dev/attachments/20210316/3db75189/attachment.htm>