[scribus-dev] build failure in util_ghostscript.cpp

[ale rimoldi]

hi

> On 06/04/2018 08:48 PM, Peter Linnell wrote:
> > On Mon, 4 Jun 2018 20:19:49 -0400
> > Gregory Pittman <gpittman at iglou.com> wrote:
> >   
> >> [  9%] Building CXX object
> >> scribus/CMakeFiles/scribus.dir/util_ghostscript.cpp.o
> >> /home/gregp/development/Scribus15x/scribus/util_ghostscript.cpp:251:13:
> >> warning: In the GNU C Library, "major" is defined
> >>  by <sys/sysmacros.h>. For historical compatibility, it is
> >>  currently defined by <sys/types.h> as well, but we plan to
> >>  remove this soon. To use "major", include <sys/sysmacros.h>
> >>  directly. If you did not intend to use a system-defined macro
> >>  "major", you should undefine it after including <sys/types.h>.
> >>   int major(0), minor(0);
> >>              ^~~~~~~~~~~~
> >>
> >>
> >>
> >>
> >>
> >> /home/gregp/development/Scribus15x/scribus/util_ghostscript.cpp:251:13:
> >> warning: In the GNU C Library, "minor" is defined
> >>  by <sys/sysmacros.h>. For historical compatibility, it is
> >>  currently defined by <sys/types.h> as well, but we plan to
> >>  remove this soon. To use "minor", include <sys/sysmacros.h>
> >>  directly. If you did not intend to use a system-defined macro
> >>  "minor", you should undefine it after including <sys/types.h>.
> >>   int major(0), minor(0);
> >>              ^~~~~~~~~~~~
> >>
> >>
> >>
> >>
> >>
> >> /home/gregp/development/Scribus15x/scribus/util_ghostscript.cpp: In
> >> function ‘bool getNumericGSVersion(int&)’:
> >> /home/gregp/development/Scribus15x/scribus/util_ghostscript.cpp:252:26:
> >> error: ‘major’ was not declared in this scope
> >>   if (getNumericGSVersion(major, minor))
> >>                           ^~~~~
> >> /home/gregp/development/Scribus15x/scribus/util_ghostscript.cpp:252:33:
> >> error: ‘minor’ was not declared in this scope
> >>   if (getNumericGSVersion(major, minor))
> >>                                  ^~~~~
> >> make[2]: *** [scribus/CMakeFiles/scribus.dir/build.make:8582:
> >> scribus/CMakeFiles/scribus.dir/util_ghostscript.cpp.o] Error 1
> >> make[1]: *** [CMakeFiles/Makefile2:154:
> >> scribus/CMakeFiles/scribus.dir/all] Error 2
> >> make: *** [Makefile:152: all] Error 2
> >>
> >> Greg  
> > 
> > G++-8 ?
> >   
> 
> Hi Peter,
> 
> Not sure what you mean.
> My gcc-c++ is 7.3.1 on Fedora 27.

jean has pushed a fix after lunch...

https://github.com/scribusproject/scribus/commit/4e05c58c6666c96e17cc725533069de014d2089c

can you please test it?

ciao
a.l.e