[scribus-dev] something wrong with 1.5.4svn pdflib_core.cpp

[Gregory Pittman]

I just updated with svn and make failed when it got to pdflib_core.cpp:

[  9%] Building CXX object scribus/CMakeFiles/scribus.dir/pdflib_core.cpp.o
/home/gregp/development/Scribus15x/scribus/pdflib_core.cpp: In member
function ‘bool PDFLibCore::PDF_TemplatePage(const ScPage*, bool)’:
/home/gregp/development/Scribus15x/scribus/pdflib_core.cpp:2777:73:
error: invalid initialization of non-const reference of type ‘QString&’
from an rvalue of type ‘QString’
         ScPattern* strokePattern =
doc.checkedPattern(ite->strokePattern());
                                                       ~~~~~~~~~~~~~~~~~~^~
In file included from
/home/gregp/development/Scribus15x/scribus/scribus.h:58:0,
                 from
/home/gregp/development/Scribus15x/scribus/scribuscore.h:27,
                 from
/home/gregp/development/Scribus15x/scribus/pdflib_core.cpp:80:
/home/gregp/development/Scribus15x/scribus/scribusdoc.h:701:13: note:
initializing argument 1 of ‘ScPattern* ScribusDoc::checkedPattern(QString&)’
  ScPattern* checkedPattern(QString &name);
             ^~~~~~~~~~~~~~
/home/gregp/development/Scribus15x/scribus/pdflib_core.cpp:2832:72:
error: invalid initialization of non-const reference of type ‘QString&’
from an rvalue of type ‘QString’
        ScPattern* strokePattern = doc.checkedPattern(ite->strokePattern());
                                                      ~~~~~~~~~~~~~~~~~~^~
In file included from
/home/gregp/development/Scribus15x/scribus/scribus.h:58:0,
                 from
/home/gregp/development/Scribus15x/scribus/scribuscore.h:27,
                 from
/home/gregp/development/Scribus15x/scribus/pdflib_core.cpp:80:
/home/gregp/development/Scribus15x/scribus/scribusdoc.h:701:13: note:
initializing argument 1 of ‘ScPattern* ScribusDoc::checkedPattern(QString&)’
  ScPattern* checkedPattern(QString &name);
             ^~~~~~~~~~~~~~
/home/gregp/development/Scribus15x/scribus/pdflib_core.cpp:2952:73:
error: invalid initialization of non-const reference of type ‘QString&’
from an rvalue of type ‘QString’
         ScPattern* strokePattern =
doc.checkedPattern(ite->strokePattern());
                                                       ~~~~~~~~~~~~~~~~~~^~
In file included from
/home/gregp/development/Scribus15x/scribus/scribus.h:58:0,
                 from
/home/gregp/development/Scribus15x/scribus/scribuscore.h:27,
                 from
/home/gregp/development/Scribus15x/scribus/pdflib_core.cpp:80:
/home/gregp/development/Scribus15x/scribus/scribusdoc.h:701:13: note:
initializing argument 1 of ‘ScPattern* ScribusDoc::checkedPattern(QString&)’
  ScPattern* checkedPattern(QString &name);
             ^~~~~~~~~~~~~~
/home/gregp/development/Scribus15x/scribus/pdflib_core.cpp:3053:73:
error: invalid initialization of non-const reference of type ‘QString&’
from an rvalue of type ‘QString’
         ScPattern* strokePattern =
doc.checkedPattern(ite->strokePattern());
                                                       ~~~~~~~~~~~~~~~~~~^~


There is more than this, but it's a similar pattern afterward.

Greg