[scribus-dev] Dear Oman team

[Khaled Hosny]

On Sat, Oct 31, 2015 at 10:19:51AM -0500, Kunda Loves Scribus wrote:
> On Sat, Oct 31, 2015 at 8:44 AM, JLuc <jluc at no-log.org> wrote:
> 
> > Le 30/10/2015 21:53, Kunda Loves Scribus a écrit :
> >
> >> Please trust that we're looking at you patches and testing them. There
> >> are only 2 active committing devs ATM and they
> >> volunteer their time.
> >> So in the mean time, feel free to work on other Scribus issues.
> >>
> >
> > I would like to add something about submitting patches :
> >
> > Please test your patch carefully before submiting it.
> >
> > Better : submit it to another student that will test it
> > and will provide you with its feedback : "it's ok" or "it's not ok",
> > so you can debug it in case it needs it.
> >
> > Thanks a lot for your dedication,
> > JLuc
> 
> 
> I agree with JLuc, by doing this it saves precious volunteer time for
> anyone involved that works with the patch.

Do you have examples of untested patches being sent? AFAIK, all patches
are tested or otherwise how the contributor knows it fixed the issue. Or
may be I misunderstood the kind of testing needed?

> And... there is another option for testing patches: Github.
> 
> Important note: For Scribus, Github serves officially _only_ as a mirror
> for SVN ie. so no code commits happen on it but...

And that is enough reason to not bother about it, it is not an official
part of Scribus development and is just increasing the work needed and a
waste of everyones time. If Scribus wants/needs continuous integration,
then it should be part of the project and not delegated to some obscure,
unrelated GitHub repository.

Regards,
Khaled