[scribus-dev] Please review / merge this patch

[JLuc]

Le 06/05/2014 22:55, Craig Bradney a écrit :
> On 6/05/2014 2:43 pm, JLuc wrote:
>> Le 04/05/2014 20:08, Craig Bradney a écrit :
>>>> Please find thereafter a patch that brings keyboard shortcuts for styles :
>>>> http://bugs.scribus.net/view.php?id=10289
>>
>>> Right now, Scribus shortcuts do not allow a differentiation between application mode shortcuts or
>>> text mode shortcuts, nor do we set up actions with default keys like a,A,b,B.
>>
>>> So, with this patch, styles can have a shortcut set as 'b', or 'shift b' for example.. which then
>>> stops you typing any more 'b's.
>>>
>>> Any thoughts on how to avoid that?
>>
>> Well, that would be the user's choice.
>> In case you want to protect the user from himself,
>> the style dialog could refuse to record shortcuts like plain a-zA-Z for styles.
>> For such keys it would require CTRL or ALT (i dont know about Apple© keyboards).
>> Would that fix the concern ?
>>
>
> It leads to a bigger question about shortcut handling within Scribus.
>
> Jean and I are working on this from two directions - both the short cuts for styles and enhancing
> shortcut management.

Ah. If you think your work will not land in the coming weeks,
then it would be easy and cool to merge the proposed patch as is
- easy because it's ready ; and cool for the happy few who use the 1.5 -

btw is there a public repo to see or test your works ?

JLuc