[scribus-dev] tables gsoc: primitive code review
Nick Shaforostoff
shafff at ukr.net
Fri Jul 15 16:04:01 UTC 2011
ok, in pageitem_table.h i suggest changing these kind of lines:
/// Vertical positions of rows.
QList<qreal> m_rowPositions;
/// Height of rows.
QList<qreal> m_rowHeights;
into
struct RowPosHeight
{
qreal position, height
};
QList<RowPosHeight> m_rowPosHeights;
this would reduce memory overhead and also will make code a bit faster, as those two vars are often accessed/modified together.
same for columns
More information about the scribus-dev
mailing list