r24892 by craig - Qt6 clazy review: Normalise connect calls, other minor fixes
scribus-commit
scribus-commit at lists.scribus.net
Thu Feb 3 21:15:24 UTC 2022
Author: craig
Date: Thu Feb 3 21:15:24 2022
New Revision: 24892
URL: http://scribus.net/websvn/listing.php?repname=Scribus&sc=1&rev=24892
Log:
Qt6 clazy review: Normalise connect calls, other minor fixes
Modified:
trunk/Scribus/scribus/downloadmanager/scdlmgr.cpp
trunk/Scribus/scribus/plugins/fontpreview/fontpreview.cpp
trunk/Scribus/scribus/ui/colorlistbox.cpp
trunk/Scribus/scribus/ui/colorsandfills.cpp
trunk/Scribus/scribus/ui/pagelayout.cpp
trunk/Scribus/scribus/ui/pagepalette_masterpages.cpp
trunk/Scribus/scribus/ui/pagepropertiesdialog.cpp
trunk/Scribus/scribus/ui/picstatus.cpp
trunk/Scribus/scribus/ui/replacecolors.cpp
trunk/Scribus/scribus/ui/resourcemanager.cpp
trunk/Scribus/scribus/ui/smcellstyle.cpp
trunk/Scribus/scribus/ui/smlinestyle.cpp
trunk/Scribus/scribus/ui/smpstylewidget.cpp
trunk/Scribus/scribus/ui/smtablestyle.cpp
trunk/Scribus/scribus/ui/smtextstyles.cpp
trunk/Scribus/scribus/ui/stylemanager.cpp
trunk/Scribus/scribus/ui/swatchcombo.cpp
trunk/Scribus/scribus/ui/symbolpalette.cpp
trunk/Scribus/scribus/ui/tabpdfoptions.cpp
trunk/Scribus/scribus/ui/tabruler.cpp
trunk/Scribus/scribus/ui/useprintermarginsdialog.cpp
trunk/Scribus/scribus/util_ghostscript.cpp
trunk/Scribus/scribus/util_math.cpp
Modified: trunk/Scribus/scribus/downloadmanager/scdlmgr.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/downloadmanager/scdlmgr.cpp
==============================================================================
--- trunk/Scribus/scribus/downloadmanager/scdlmgr.cpp (original)
+++ trunk/Scribus/scribus/downloadmanager/scdlmgr.cpp Thu Feb 3 21:15:24 2022
@@ -15,9 +15,9 @@
: QObject(parent)
{
m_thread=new ScDLThread();
- connect(m_thread, SIGNAL(fileReceived(const QString &)), this, SLOT(dlReceived(QString)));
- connect(m_thread, SIGNAL(fileFailed(const QString &)), this, SLOT(dlFailed(QString)));
- connect(m_thread, SIGNAL(fileStarted(const QString &)), this, SLOT(dlStarted(QString)));
+ connect(m_thread, SIGNAL(fileReceived(QString)), this, SLOT(dlReceived(QString)));
+ connect(m_thread, SIGNAL(fileFailed(QString)), this, SLOT(dlFailed(QString)));
+ connect(m_thread, SIGNAL(fileStarted(QString)), this, SLOT(dlStarted(QString)));
connect(m_thread, SIGNAL(fileDownloadProgress(qint64,qint64)), this, SIGNAL(fileDownloadProgress(qint64,qint64)));
//connect(thread, SIGNAL(finished()), this, SIGNAL(finished()));
connect(m_thread, SIGNAL(finished()), this, SLOT(moveFinishedDownloads()));
Modified: trunk/Scribus/scribus/plugins/fontpreview/fontpreview.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/plugins/fontpreview/fontpreview.cpp
==============================================================================
--- trunk/Scribus/scribus/plugins/fontpreview/fontpreview.cpp (original)
+++ trunk/Scribus/scribus/plugins/fontpreview/fontpreview.cpp Thu Feb 3 21:15:24 2022
@@ -95,7 +95,7 @@
connect(cancelButton, SIGNAL(clicked()), this, SLOT(cancelButton_clicked()));
connect(resetDisplayButton, SIGNAL(clicked()), this, SLOT(resetDisplayButton_clicked()));
connect(sizeSpin, SIGNAL(valueChanged(int)), this, SLOT(sizeSpin_valueChanged(int)));
- connect(fontList->selectionModel(), SIGNAL(currentChanged(const QModelIndex&,const QModelIndex&)), this, SLOT(fontList_currentChanged(const QModelIndex&, const QModelIndex&)));
+ connect(fontList->selectionModel(), SIGNAL(currentChanged(QModelIndex,QModelIndex)), this, SLOT(fontList_currentChanged(QModelIndex,QModelIndex)));
connect(extendedCheckBox, SIGNAL(clicked(bool)), this, SLOT(setExtendedView(bool)));
}
Modified: trunk/Scribus/scribus/ui/colorlistbox.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/ui/colorlistbox.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/colorlistbox.cpp (original)
+++ trunk/Scribus/scribus/ui/colorlistbox.cpp Thu Feb 3 21:15:24 2022
@@ -184,12 +184,10 @@
QListView::setModel(new ColorListModel(this));
setPixmapType(ColorListBox::widePixmap);
- connect(this, SIGNAL(clicked(QModelIndex)), this, SLOT(emitItemClicked(QModelIndex)));
+ connect(this, SIGNAL(clicked(QModelIndex)), this, SLOT(emitItemClicked(QModelIndex)));
connect(this, SIGNAL(doubleClicked(QModelIndex)), this, SLOT(emitItemDoubleClicked(QModelIndex)));
- connect(this->selectionModel(), SIGNAL(currentChanged(QModelIndex, QModelIndex)),
- this, SLOT(emitCurrentChanged(QModelIndex, QModelIndex)));
- connect(this->selectionModel(), SIGNAL(selectionChanged(QItemSelection,QItemSelection)),
- this, SIGNAL(itemSelectionChanged()));
+ connect(this->selectionModel(), SIGNAL(currentChanged(QModelIndex,QModelIndex)), this, SLOT(emitCurrentChanged(QModelIndex,QModelIndex)));
+ connect(this->selectionModel(), SIGNAL(selectionChanged(QItemSelection,QItemSelection)), this, SIGNAL(itemSelectionChanged()));
connect(this, SIGNAL(contextMenuRequested()), this, SLOT(slotRightClick()));
}
Modified: trunk/Scribus/scribus/ui/colorsandfills.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/ui/colorsandfills.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/colorsandfills.cpp (original)
+++ trunk/Scribus/scribus/ui/colorsandfills.cpp Thu Feb 3 21:15:24 2022
@@ -150,10 +150,10 @@
dataTree->setCurrentItem(dataTree->topLevelItem(0));
itemSelected(dataTree->currentItem());
- connect(dataTree, SIGNAL(itemClicked(QTreeWidgetItem*, int)), this, SLOT(itemSelected(QTreeWidgetItem*)));
- connect(dataTree, SIGNAL(itemDoubleClicked(QTreeWidgetItem*, int)), this, SLOT(selEditColor(QTreeWidgetItem*)));
+ connect(dataTree, SIGNAL(itemClicked(QTreeWidgetItem*,int)), this, SLOT(itemSelected(QTreeWidgetItem*)));
+ connect(dataTree, SIGNAL(itemDoubleClicked(QTreeWidgetItem*,int)), this, SLOT(selEditColor(QTreeWidgetItem*)));
connect(dataTree, SIGNAL(itemSelectionChanged()), this, SLOT(itemSelectionChanged()));
- connect(dataTree, SIGNAL(customContextMenuRequested (const QPoint &)), this, SLOT(slotRightClick(QPoint)));
+ connect(dataTree, SIGNAL(customContextMenuRequested(QPoint)), this, SLOT(slotRightClick(QPoint)));
connect(newButton, SIGNAL(clicked()), this, SLOT(createNew()));
connect(editButton, SIGNAL(clicked()), this, SLOT(editColorItem()));
connect(duplicateButton, SIGNAL(clicked()), this, SLOT(duplicateColorItem()));
Modified: trunk/Scribus/scribus/ui/pagelayout.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/ui/pagelayout.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/pagelayout.cpp (original)
+++ trunk/Scribus/scribus/ui/pagelayout.cpp Thu Feb 3 21:15:24 2022
@@ -114,7 +114,7 @@
// We need change combos width setMaximumWidth(minimumSizeHint().width());
if (modus)
- connect(layoutsView, SIGNAL(itemClicked(QListWidgetItem *)), this, SLOT(itemSelected(QListWidgetItem* )));
+ connect(layoutsView, SIGNAL(itemClicked(QListWidgetItem*)), this, SLOT(itemSelected(QListWidgetItem*)));
else
connect(layoutsCombo, SIGNAL(activated(int)), this, SLOT(itemSelected(int)));
connect(firstPage, SIGNAL(activated(int)), this, SIGNAL(selectedFirstPage(int)));
@@ -176,7 +176,7 @@
{
layoutsView->setCurrentRow(nr);
layoutsView->item(nr)->setSelected(true);
- connect(layoutsView, SIGNAL(itemClicked(QListWidgetItem *)), this, SLOT(itemSelected(QListWidgetItem* )));
+ connect(layoutsView, SIGNAL(itemClicked(QListWidgetItem*)), this, SLOT(itemSelected(QListWidgetItem*)));
}
else
{
Modified: trunk/Scribus/scribus/ui/pagepalette_masterpages.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/ui/pagepalette_masterpages.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/pagepalette_masterpages.cpp (original)
+++ trunk/Scribus/scribus/ui/pagepalette_masterpages.cpp Thu Feb 3 21:15:24 2022
@@ -105,10 +105,8 @@
connect(deleteButton , SIGNAL(clicked()), this, SLOT(deleteMasterPage()));
connect(newButton , SIGNAL(clicked()), this, SLOT(newMasterPage()));
connect(importButton , SIGNAL(clicked()), this, SLOT(importPage()));
- connect(masterPageListBox, SIGNAL(itemClicked(QListWidgetItem*)),
- this, SLOT(selectMasterPage(QListWidgetItem*)));
- connect(masterPageListBox, SIGNAL(itemChanged(QListWidgetItem*)),
- this, SLOT(renameMasterPage( QListWidgetItem*)));
+ connect(masterPageListBox, SIGNAL(itemClicked(QListWidgetItem*)), this, SLOT(selectMasterPage(QListWidgetItem*)));
+ connect(masterPageListBox, SIGNAL(itemChanged(QListWidgetItem*)), this, SLOT(renameMasterPage(QListWidgetItem*)));
connect(finishButton , SIGNAL(released()), this, SIGNAL(finished()));
}
Modified: trunk/Scribus/scribus/ui/pagepropertiesdialog.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/ui/pagepropertiesdialog.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/pagepropertiesdialog.cpp (original)
+++ trunk/Scribus/scribus/ui/pagepropertiesdialog.cpp Thu Feb 3 21:15:24 2022
@@ -167,10 +167,10 @@
heightSpinBox->setEnabled(isCustom);
widthSpinBox->setEnabled(isCustom);
// signals and slots connections
- connect( okButton, SIGNAL( clicked() ), this, SLOT( accept() ) );
- connect( cancelButton, SIGNAL( clicked() ), this, SLOT( reject() ) );
+ connect(okButton, SIGNAL(clicked()), this, SLOT(accept()));
+ connect(cancelButton, SIGNAL(clicked()), this, SLOT(reject()));
connect(orientationQComboBox, SIGNAL(activated(int)), this, SLOT(setOrientation(int)));
- connect(sizeQComboBox, SIGNAL(activated(const QString &)), this, SLOT(setPageSize()));
+ connect(sizeQComboBox, SIGNAL(activated(QString)), this, SLOT(setPageSize()));
connect(widthSpinBox, SIGNAL(valueChanged(double)), this, SLOT(setPageWidth(double)));
connect(heightSpinBox, SIGNAL(valueChanged(double)), this, SLOT(setPageHeight(double)));
Modified: trunk/Scribus/scribus/ui/picstatus.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/ui/picstatus.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/picstatus.cpp (original)
+++ trunk/Scribus/scribus/ui/picstatus.cpp Thu Feb 3 21:15:24 2022
@@ -80,7 +80,7 @@
connect(effectsButton, SIGNAL(clicked()), this, SLOT(doImageEffects()));
connect(buttonLayers, SIGNAL(clicked()), this, SLOT(doImageExtProp()));
connect(buttonEdit, SIGNAL(clicked()), this, SLOT(doEditImage()));
- connect(imageViewArea, SIGNAL(customContextMenuRequested (const QPoint &)), this, SLOT(slotRightClick()));
+ connect(imageViewArea, SIGNAL(customContextMenuRequested(QPoint)), this, SLOT(slotRightClick()));
}
QPixmap PicStatus::createImgIcon(PageItem* item)
Modified: trunk/Scribus/scribus/ui/replacecolors.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/ui/replacecolors.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/replacecolors.cpp (original)
+++ trunk/Scribus/scribus/ui/replacecolors.cpp Thu Feb 3 21:15:24 2022
@@ -60,7 +60,7 @@
updateReplacementTable();
removeButton->setEnabled(false);
connect(addButton, SIGNAL(clicked()), this, SLOT(addColor()));
- connect(replacementTable, SIGNAL(cellClicked(int, int)), this, SLOT(selReplacement(int)));
+ connect(replacementTable, SIGNAL(cellClicked(int,int)), this, SLOT(selReplacement(int)));
connect(removeButton, SIGNAL(clicked()), this, SLOT(delReplacement()));
connect(editButton, SIGNAL(clicked()), this, SLOT(editReplacement()));
}
Modified: trunk/Scribus/scribus/ui/resourcemanager.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/ui/resourcemanager.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/resourcemanager.cpp (original)
+++ trunk/Scribus/scribus/ui/resourcemanager.cpp Thu Feb 3 21:15:24 2022
@@ -942,9 +942,9 @@
for (const QString& f : qAsConst(m_dataFiles))
ScQApp->dlManager()->addURL("https://services.scribus.net/" + f + ".sha256", true, ScPaths::downloadDir(), ScPaths::downloadDir());
connect(ScQApp->dlManager(), SIGNAL(finished()), this, SLOT(downloadListFinished()));
- connect(ScQApp->dlManager(), SIGNAL(fileReceived(const QString&)), this, SLOT(updateProgressBar()));
- connect(ScQApp->dlManager(), SIGNAL(fileFailed(const QString&)), this, SLOT(updateProgressBar()));
- connect(ScQApp->dlManager(), SIGNAL(fileFailed(const QString&)), this, SLOT(updateProgressBar()));
+ connect(ScQApp->dlManager(), SIGNAL(fileReceived(QString)), this, SLOT(updateProgressBar()));
+ connect(ScQApp->dlManager(), SIGNAL(fileFailed(QString)), this, SLOT(updateProgressBar()));
+ connect(ScQApp->dlManager(), SIGNAL(fileFailed(QString)), this, SLOT(updateProgressBar()));
connect(ScQApp->dlManager(), SIGNAL(fileDownloadProgress(qint64, qint64)), this, SLOT(updateProgressData(qint64, qint64)));
ScQApp->dlManager()->startDownloads();
}
@@ -1341,9 +1341,9 @@
{
downloadProgressBar->setRange(0, dlCount);
connect(ScQApp->dlManager(), SIGNAL(finished()), this, SLOT(downloadFilesFinished()));
- connect(ScQApp->dlManager(), SIGNAL(fileReceived(const QString&)), this, SLOT(updateProgressBar()));
- connect(ScQApp->dlManager(), SIGNAL(fileFailed(const QString&)), this, SLOT(updateProgressBar()));
- connect(ScQApp->dlManager(), SIGNAL(fileDownloadProgress(qint64, qint64)), this, SLOT(updateProgressData(qint64, qint64)));
+ connect(ScQApp->dlManager(), SIGNAL(fileReceived(QString)), this, SLOT(updateProgressBar()));
+ connect(ScQApp->dlManager(), SIGNAL(fileFailed(QString)), this, SLOT(updateProgressBar()));
+ connect(ScQApp->dlManager(), SIGNAL(fileDownloadProgress(qint64,qint64)), this, SLOT(updateProgressData(qint64,qint64)));
ScQApp->dlManager()->startDownloads();
}
}
Modified: trunk/Scribus/scribus/ui/smcellstyle.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/ui/smcellstyle.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/smcellstyle.cpp (original)
+++ trunk/Scribus/scribus/ui/smcellstyle.cpp Thu Feb 3 21:15:24 2022
@@ -420,9 +420,9 @@
{
if (!m_page)
return;
- connect(m_page->fillColor, SIGNAL(currentTextChanged(const QString&)), this, SLOT(slotFillColor()));
+ connect(m_page->fillColor, SIGNAL(currentTextChanged(QString)), this, SLOT(slotFillColor()));
connect(m_page->fillShade, SIGNAL(clicked()), this, SLOT(slotFillShade()));
- connect(m_page->parentCombo, SIGNAL(currentTextChanged(const QString&)), this, SLOT(slotParentChanged(const QString&)));
+ connect(m_page->parentCombo, SIGNAL(currentTextChanged(QString)), this, SLOT(slotParentChanged(QString)));
}
void SMCellStyle::removeConnections()
Modified: trunk/Scribus/scribus/ui/smlinestyle.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/ui/smlinestyle.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/smlinestyle.cpp (original)
+++ trunk/Scribus/scribus/ui/smlinestyle.cpp Thu Feb 3 21:15:24 2022
@@ -415,7 +415,7 @@
connect(m_widget->removeButton, SIGNAL(clicked()), this, SLOT(slotDeleteLine()));
connect(m_widget->endCombo, SIGNAL(activated(int)), this, SLOT(slotSetEnd(int)));
connect(m_widget->joinCombo, SIGNAL(activated(int)), this, SLOT(slotSetJoin(int)));
- connect(m_widget->colorCombo, SIGNAL(activated(const QString&)), this, SLOT(slotColor(const QString&)));
+ connect(m_widget->colorCombo, SIGNAL(activated(QString)), this, SLOT(slotColor(QString)));
connect(m_widget->dashCombo, SIGNAL(activated(int)), this, SLOT(slotLineStyle(int)));
connect(m_widget->shadeBox, SIGNAL(valueChanged(int)), this, SLOT(slotShade(int)));
connect(m_widget->lineWidth, SIGNAL(valueChanged(double)), this, SLOT(slotLineWidth()));
Modified: trunk/Scribus/scribus/ui/smpstylewidget.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/ui/smpstylewidget.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/smpstylewidget.cpp (original)
+++ trunk/Scribus/scribus/ui/smpstylewidget.cpp Thu Feb 3 21:15:24 2022
@@ -1195,7 +1195,7 @@
QApplication::setOverrideCursor(QCursor(Qt::WaitCursor));
m_enhanced = new CharSelectEnhanced(this);
m_enhanced->setModal(true);
- connect(m_enhanced, SIGNAL(insertSpecialChars(const QVector<uint> &)), this, SLOT(insertSpecialChars(const QVector<uint> &)));
+ connect(m_enhanced, SIGNAL(insertSpecialChars(QVector<uint>)), this, SLOT(insertSpecialChars(QVector<uint>)));
connect(m_enhanced, SIGNAL(paletteShown(bool)), bulletCharTableButton, SLOT(setChecked(bool)));
m_enhanced->setDoc(m_Doc);
m_enhanced->setEnabled(true);
Modified: trunk/Scribus/scribus/ui/smtablestyle.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/ui/smtablestyle.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/smtablestyle.cpp (original)
+++ trunk/Scribus/scribus/ui/smtablestyle.cpp Thu Feb 3 21:15:24 2022
@@ -422,9 +422,9 @@
{
if (!m_page)
return;
- connect(m_page->fillColor, SIGNAL(currentTextChanged(const QString&)), this, SLOT(slotFillColor()));
+ connect(m_page->fillColor, SIGNAL(currentTextChanged(QString)), this, SLOT(slotFillColor()));
connect(m_page->fillShade, SIGNAL(clicked()), this, SLOT(slotFillShade()));
- connect(m_page->parentCombo, SIGNAL(currentTextChanged(const QString&)), this, SLOT(slotParentChanged(const QString&)));
+ connect(m_page->parentCombo, SIGNAL(currentTextChanged(QString)), this, SLOT(slotParentChanged(QString)));
}
void SMTableStyle::removeConnections()
Modified: trunk/Scribus/scribus/ui/smtextstyles.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/ui/smtextstyles.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/smtextstyles.cpp (original)
+++ trunk/Scribus/scribus/ui/smtextstyles.cpp Thu Feb 3 21:15:24 2022
@@ -543,8 +543,8 @@
connect(m_pwidget->tabList->rightIndentSpin, SIGNAL(valueChanged(double)), this, SLOT(slotRightIndent()));
connect(m_pwidget->tabList->firstLineSpin, SIGNAL(valueChanged(double)), this, SLOT(slotFirstLine()));
- connect(m_pwidget->parentCombo, SIGNAL(currentTextChanged(const QString&)), this, SLOT(slotParentChanged(const QString&)));
- connect(m_pwidget->backColor_, SIGNAL(currentTextChanged(const QString&)), this, SLOT(slotBackPColor()));
+ connect(m_pwidget->parentCombo, SIGNAL(currentTextChanged(QString)), this, SLOT(slotParentChanged(QString)));
+ connect(m_pwidget->backColor_, SIGNAL(currentTextChanged(QString)), this, SLOT(slotBackPColor()));
connect(m_pwidget->backShade_, SIGNAL(clicked()), this, SLOT(slotBackPShade()));
// character attributes
@@ -557,9 +557,9 @@
connect(m_pwidget->cpage->effects_->UnderlineVal->LWidth, SIGNAL(valueChanged(double)), this, SLOT(slotEffectProperties()));
connect(m_pwidget->cpage->effects_->StrikeVal->LPos, SIGNAL(valueChanged(double)), this, SLOT(slotEffectProperties()));
connect(m_pwidget->cpage->effects_->StrikeVal->LWidth, SIGNAL(valueChanged(double)), this, SLOT(slotEffectProperties()));
- connect(m_pwidget->cpage->fillColor_, SIGNAL(currentTextChanged(const QString&)), this, SLOT(slotFillColor()));
+ connect(m_pwidget->cpage->fillColor_, SIGNAL(currentTextChanged(QString)), this, SLOT(slotFillColor()));
connect(m_pwidget->cpage->fillShade_, SIGNAL(clicked()), this, SLOT(slotFillShade()));
- connect(m_pwidget->cpage->strokeColor_, SIGNAL(currentTextChanged(const QString&)), this, SLOT(slotStrokeColor()));
+ connect(m_pwidget->cpage->strokeColor_, SIGNAL(currentTextChanged(QString)), this, SLOT(slotStrokeColor()));
connect(m_pwidget->cpage->strokeShade_, SIGNAL(clicked()), this, SLOT(slotStrokeShade()));
connect(m_pwidget->cpage->language_, SIGNAL(activated(int)), this, SLOT(slotLanguage()));
connect(m_pwidget->cpage->fontSize_, SIGNAL(valueChanged(double)), this, SLOT(slotFontSize()));
@@ -568,15 +568,15 @@
connect(m_pwidget->cpage->tracking_, SIGNAL(valueChanged(double)), this, SLOT(slotTracking()));
connect(m_pwidget->cpage->widthSpaceSpin, SIGNAL(valueChanged(double)), this, SLOT(slotWordTracking()));
connect(m_pwidget->cpage->baselineOffset_, SIGNAL(valueChanged(double)), this, SLOT(slotBaselineOffset()));
- connect(m_pwidget->cpage->parentCombo, SIGNAL(currentTextChanged(const QString&)), this, SLOT(slotCharParentChanged(const QString&)));
- connect(m_pwidget->cpage->backColor_, SIGNAL(currentTextChanged(const QString&)), this, SLOT(slotBackColor()));
+ connect(m_pwidget->cpage->parentCombo, SIGNAL(currentTextChanged(QString)), this, SLOT(slotCharParentChanged(QString)));
+ connect(m_pwidget->cpage->backColor_, SIGNAL(currentTextChanged(QString)), this, SLOT(slotBackColor()));
connect(m_pwidget->cpage->backShade_, SIGNAL(clicked()), this, SLOT(slotBackShade()));
connect(m_pwidget->cpage->fontfeaturesSetting,SIGNAL(changed()), this, SLOT(slotFontFeatures()));
connect(m_pwidget->cpage->hyphenCharLineEdit, SIGNAL(textChanged(QString)), this, SLOT(slotHyphenChar()));
connect(m_pwidget->cpage->smallestWordSpinBox, SIGNAL(valueChanged(int)), this, SLOT(slotWordMin()));
// Referenced character style changes
- connect(m_cstyleItem, SIGNAL(charStylesDeleted(const QList<RemoveItem>&)), this, SLOT(slotCharStylesDeleted(const QList<RemoveItem>&)));
+ connect(m_cstyleItem, SIGNAL(charStylesDeleted(QList<RemoveItem>)), this, SLOT(slotCharStylesDeleted(QList<RemoveItem>)));
}
void SMParagraphStyle::removeConnections()
@@ -2280,9 +2280,9 @@
connect(m_page->effects_->UnderlineVal->LWidth, SIGNAL(valueChanged(double)), this, SLOT(slotEffectProperties()));
connect(m_page->effects_->StrikeVal->LPos, SIGNAL(valueChanged(double)), this, SLOT(slotEffectProperties()));
connect(m_page->effects_->StrikeVal->LWidth, SIGNAL(valueChanged(double)), this, SLOT(slotEffectProperties()));
- connect(m_page->fillColor_, SIGNAL(currentTextChanged(const QString&)), this, SLOT(slotFillColor()));
+ connect(m_page->fillColor_, SIGNAL(currentTextChanged(QString)), this, SLOT(slotFillColor()));
connect(m_page->fillShade_, SIGNAL(clicked()), this, SLOT(slotFillShade()));
- connect(m_page->strokeColor_, SIGNAL(currentTextChanged(const QString&)), this, SLOT(slotStrokeColor()));
+ connect(m_page->strokeColor_, SIGNAL(currentTextChanged(QString)), this, SLOT(slotStrokeColor()));
connect(m_page->strokeShade_, SIGNAL(clicked()), this, SLOT(slotStrokeShade()));
connect(m_page->language_, SIGNAL(activated(int)), this, SLOT(slotLanguage()));
connect(m_page->fontSize_, SIGNAL(valueChanged(double)), this, SLOT(slotFontSize()));
@@ -2291,8 +2291,8 @@
connect(m_page->tracking_, SIGNAL(valueChanged(double)), this, SLOT(slotTracking()));
connect(m_page->widthSpaceSpin, SIGNAL(valueChanged(double)), this, SLOT(slotWordTracking()));
connect(m_page->baselineOffset_, SIGNAL(valueChanged(double)), this, SLOT(slotBaselineOffset()));
- connect(m_page->parentCombo, SIGNAL(currentTextChanged(const QString&)), this, SLOT(slotParentChanged(const QString&)));
- connect(m_page->backColor_, SIGNAL(currentTextChanged(const QString&)), this, SLOT(slotBackColor()));
+ connect(m_page->parentCombo, SIGNAL(currentTextChanged(QString)), this, SLOT(slotParentChanged(QString)));
+ connect(m_page->backColor_, SIGNAL(currentTextChanged(QString)), this, SLOT(slotBackColor()));
connect(m_page->backShade_, SIGNAL(clicked()), this, SLOT(slotBackShade()));
connect(m_page->fontfeaturesSetting, SIGNAL(changed()), this, SLOT(slotFontFeatures()));
connect(m_page->smallestWordSpinBox, SIGNAL(valueChanged(int)), this, SLOT(slotSmallestWord()));
Modified: trunk/Scribus/scribus/ui/stylemanager.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/ui/stylemanager.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/stylemanager.cpp (original)
+++ trunk/Scribus/scribus/ui/stylemanager.cpp Thu Feb 3 21:15:24 2022
@@ -72,10 +72,8 @@
connect(deleteButton, SIGNAL(clicked()), this, SLOT(slotDelete()));
connect(cloneButton, SIGNAL(clicked()), this, SLOT(slotClone()));
connect(newButton, SIGNAL(clicked()), this, SLOT(slotNew()));
- connect(styleView, SIGNAL(customContextMenuRequested(const QPoint &)),
- this, SLOT(slotRightClick(const QPoint &)));
- connect(styleView, SIGNAL(itemDoubleClicked(QTreeWidgetItem *, int)),
- this, SLOT(slotDoubleClick(QTreeWidgetItem *, int)));
+ connect(styleView, SIGNAL(customContextMenuRequested(QPoint)), this, SLOT(slotRightClick(QPoint)));
+ connect(styleView, SIGNAL(itemDoubleClicked(QTreeWidgetItem*,int)), this, SLOT(slotDoubleClick(QTreeWidgetItem*,int)));
languageChange();
slotOk();
Modified: trunk/Scribus/scribus/ui/swatchcombo.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/ui/swatchcombo.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/swatchcombo.cpp (original)
+++ trunk/Scribus/scribus/ui/swatchcombo.cpp Thu Feb 3 21:15:24 2022
@@ -39,7 +39,7 @@
setMenu(popUp);
setPopupMode(QToolButton::MenuButtonPopup);
setSizePolicy(QSizePolicy(QSizePolicy::Expanding, QSizePolicy::Fixed));
- connect(dataTree, SIGNAL(itemClicked(QTreeWidgetItem*, int)), this, SLOT(itemActivated(QTreeWidgetItem*)));
+ connect(dataTree, SIGNAL(itemClicked(QTreeWidgetItem*,int)), this, SLOT(itemActivated(QTreeWidgetItem*)));
}
void SwatchCombo::itemActivated(QTreeWidgetItem* item)
Modified: trunk/Scribus/scribus/ui/symbolpalette.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/ui/symbolpalette.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/symbolpalette.cpp (original)
+++ trunk/Scribus/scribus/ui/symbolpalette.cpp Thu Feb 3 21:15:24 2022
@@ -45,7 +45,7 @@
delegate = new ScListWidgetDelegate(this, this);
setItemDelegate(delegate);
setIconSize(QSize(48, 48));
- connect(this, SIGNAL(customContextMenuRequested (const QPoint&)), this, SLOT(HandleContextMenu(QPoint)));
+ connect(this, SIGNAL(customContextMenuRequested(QPoint)), this, SLOT(HandleContextMenu(QPoint)));
}
void SymbolView::HandleContextMenu(QPoint p)
@@ -149,13 +149,13 @@
drag->exec(Qt::CopyAction);
clearSelection();
}
-
-SymbolPalette::SymbolPalette( QWidget* parent) : ScDockPalette(parent, "Symb", Qt::WindowFlags())
-{
- setContentsMargins(3, 3, 3, 3);
- setMinimumSize( QSize( 220, 240 ) );
- setObjectName(QString::fromLocal8Bit("Symb"));
- setSizePolicy( QSizePolicy(QSizePolicy::Minimum, QSizePolicy::Minimum));
+
+SymbolPalette::SymbolPalette( QWidget* parent) : ScDockPalette(parent, "Symb", Qt::WindowFlags())
+{
+ setContentsMargins(3, 3, 3, 3);
+ setMinimumSize( QSize( 220, 240 ) );
+ setObjectName(QString::fromLocal8Bit("Symb"));
+ setSizePolicy( QSizePolicy(QSizePolicy::Minimum, QSizePolicy::Minimum));
SymbolViewWidget = new SymbolView(this);
SymbolViewWidget->clear();
setWidget( SymbolViewWidget );
Modified: trunk/Scribus/scribus/ui/tabpdfoptions.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/ui/tabpdfoptions.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/tabpdfoptions.cpp (original)
+++ trunk/Scribus/scribus/ui/tabpdfoptions.cpp Thu Feb 3 21:15:24 2022
@@ -172,7 +172,7 @@
connect(EDirection_2_2, SIGNAL(activated(int)), this, SLOT(ValidDI(int)));
connect(CheckBox10, SIGNAL(clicked()), this, SLOT(DoEffects()));
connect(EonAllPg, SIGNAL(clicked()), this, SLOT(EffectOnAll()));
- connect(InfoString, SIGNAL(textChanged(const QString &)), this, SLOT(checkInfo()));
+ connect(InfoString, SIGNAL(textChanged(QString)), this, SLOT(checkInfo()));
connect(InfoString, SIGNAL(editingFinished()), this, SLOT(checkInfo()));
connect(docBleeds, SIGNAL(clicked()), this, SLOT(doDocBleeds()));
Modified: trunk/Scribus/scribus/ui/tabruler.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/ui/tabruler.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/tabruler.cpp (original)
+++ trunk/Scribus/scribus/ui/tabruler.cpp Thu Feb 3 21:15:24 2022
@@ -605,7 +605,7 @@
connect(ruler, SIGNAL(fillCharChanged(QChar)) , this, SLOT(setTabFillChar(QChar)));
connect(typeCombo, SIGNAL(activated(int)), this, SLOT(setType()));
connect(tabFillCombo, SIGNAL(activated(int)), this, SLOT(setFillChar()));
- connect(tabFillCombo, SIGNAL(editTextChanged(const QString &)), this, SLOT(setCustomFillChar(const QString &)));
+ connect(tabFillCombo, SIGNAL(editTextChanged(QString)), this, SLOT(setCustomFillChar(QString)));
connect(ruler, SIGNAL(tabMoved(double)) , this, SLOT(setTabData(double)));
connect(ruler, SIGNAL(tabSelected()), this, SLOT(tabAdded()));
connect(ruler, SIGNAL(newTab()), this, SLOT(tabAdded()));
Modified: trunk/Scribus/scribus/ui/useprintermarginsdialog.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/ui/useprintermarginsdialog.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/useprintermarginsdialog.cpp (original)
+++ trunk/Scribus/scribus/ui/useprintermarginsdialog.cpp Thu Feb 3 21:15:24 2022
@@ -45,7 +45,7 @@
printerComboBox->insertItems(0, printerNames);
getPrinterMarginValues(printerNames.first());
marginsGroupBox->setTitle( tr("Minimum Margins for Page Size %1").arg(pageSizeName));
- connect(printerComboBox, SIGNAL(activated(const QString&)), this, SLOT(getPrinterMarginValues(const QString&)));
+ connect(printerComboBox, SIGNAL(activated(QString)), this, SLOT(getPrinterMarginValues(QString)));
}
connect(okButton, SIGNAL(clicked()), this, SLOT(accept()));
Modified: trunk/Scribus/scribus/util_ghostscript.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/util_ghostscript.cpp
==============================================================================
--- trunk/Scribus/scribus/util_ghostscript.cpp (original)
+++ trunk/Scribus/scribus/util_ghostscript.cpp Thu Feb 3 21:15:24 2022
@@ -198,12 +198,12 @@
bool testGSAvailability()
{
- QStringList args;
+// QStringList args;
PrefsManager& prefsManager = PrefsManager::instance();
return testGSAvailability(prefsManager.ghostscriptExecutable());
}
-bool testGSAvailability( const QString& gsPath )
+bool testGSAvailability(const QString& gsPath)
{
QStringList args;
args.append( "-h" );
Modified: trunk/Scribus/scribus/util_math.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=24892&path=/trunk/Scribus/scribus/util_math.cpp
==============================================================================
--- trunk/Scribus/scribus/util_math.cpp (original)
+++ trunk/Scribus/scribus/util_math.cpp Thu Feb 3 21:15:24 2022
@@ -59,7 +59,6 @@
{
uint cx = star ? c * 2 : c;
double seg = 360.0 / cx;
- double sc = rota + 180.0;
double di = factor;
double mx = 0;
double my = 0;
@@ -68,6 +67,7 @@
// calculate corner Points first
QList<QPointF> cornerPoints;
cornerPoints.reserve(cx);
+ double sc;
for (uint x = 0; x < cx; ++x)
{
sc = seg * x + 180.0 + rota;
More information about the scribus-commit
mailing list