r23846 by jghali - Small code cleanup

scribus-commit scribus-commit at lists.scribus.net
Thu May 28 01:10:12 UTC 2020


Author: jghali
Date: Thu May 28 01:10:12 2020
New Revision: 23846

URL: http://scribus.net/websvn/listing.php?repname=Scribus&sc=1&rev=23846
Log:
Small code cleanup

Modified:
    trunk/Scribus/scribus/ui/outputpreview_pdf.cpp
    trunk/Scribus/scribus/ui/outputpreview_pdf.h

Modified: trunk/Scribus/scribus/ui/outputpreview_pdf.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=23846&path=/trunk/Scribus/scribus/ui/outputpreview_pdf.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/outputpreview_pdf.cpp	(original)
+++ trunk/Scribus/scribus/ui/outputpreview_pdf.cpp	Thu May 28 01:10:12 2020
@@ -572,13 +572,13 @@
 
 	QStringList args;
 	QString tmp, tmp2, tmp3;
-	double b = m_doc->Pages->at(pageIndex)->width() * res / 72.0;
+	double w = m_doc->Pages->at(pageIndex)->width() * res / 72.0;
 	double h = m_doc->Pages->at(pageIndex)->height() * res / 72.0;
 	args.append( "-q" );
 	args.append( "-dNOPAUSE" );
 	args.append( "-dPARANOIDSAFER" );
 	args.append( QString("-r%1").arg(tmp.setNum(res)) );
-	args.append( QString("-g%1x%2").arg(tmp2.setNum(qRound(b)), tmp3.setNum(qRound(h))) );
+	args.append( QString("-g%1x%2").arg(tmp2.setNum(qRound(w)), tmp3.setNum(qRound(h))) );
 	if (m_optionsUi->enableCMYK->isChecked())
 	{
 		if (!m_haveTiffSep)
@@ -928,7 +928,6 @@
 
 void OutputPreview_PDF::setPDFOptionsToOptions(PDFOptions& pdfOptions)
 {
-	// TODO : finish
 	m_pdfVersion = pdfOptions.Version;
 
 	if (pdfOptions.UseRGB)
@@ -946,7 +945,6 @@
 
 void OutputPreview_PDF::setPDFOptionsToUi(PDFOptions& pdfOptions)
 {
-	// TODO : finish
 	m_optionsUi->pdfVersionCombo->setPDFXEnabled(m_doc->HasCMS && !ScCore->PDFXProfiles.isEmpty());
 	m_optionsUi->pdfVersionCombo->setVersion(pdfOptions.Version);
 
@@ -976,7 +974,6 @@
 
 void OutputPreview_PDF::setUiOptionsToPDFOptions(PDFOptions& pdfOptions)
 {
-	// TODO : finish
 	pdfOptions.Version = m_optionsUi->pdfVersionCombo->version();
 	if (!pdfOptions.Version.supportsOCGs())
 		pdfOptions.useLayers = false;
@@ -1041,7 +1038,6 @@
 
 void OutputPreview_PDF::updateOptionsFromUI()
 {
-	// TODO : finish
 	m_pdfVersion = m_optionsUi->pdfVersionCombo->version();
 	m_pdfOutputMode = m_optionsUi->outputModeCombo->currentIndex();
 	m_mirrorH = m_optionsUi->mirrorH->isChecked();

Modified: trunk/Scribus/scribus/ui/outputpreview_pdf.h
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=23846&path=/trunk/Scribus/scribus/ui/outputpreview_pdf.h
==============================================================================
--- trunk/Scribus/scribus/ui/outputpreview_pdf.h	(original)
+++ trunk/Scribus/scribus/ui/outputpreview_pdf.h	Thu May 28 01:10:12 2020
@@ -59,7 +59,7 @@
 	bool m_mirrorH { false };
 	bool m_mirrorV { false };
 	bool m_clipToMargins { false };
-	bool m_convertSpots { true };
+	bool m_convertSpots { false };
 
 	bool m_fontEmbeddingWasSet { false };
 	PDFOptions m_pdfOptions;




More information about the scribus-commit mailing list