r23824 by jghali - Fix issue with blockSignals() calls in page selector

scribus-commit scribus-commit at lists.scribus.net
Thu May 21 17:39:49 UTC 2020


Author: jghali
Date: Thu May 21 17:39:49 2020
New Revision: 23824

URL: http://scribus.net/websvn/listing.php?repname=Scribus&sc=1&rev=23824
Log:
Fix issue with blockSignals() calls in page selector

Modified:
    trunk/Scribus/scribus/ui/pageselector.cpp

Modified: trunk/Scribus/scribus/ui/pageselector.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=23824&path=/trunk/Scribus/scribus/ui/pageselector.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/pageselector.cpp	(original)
+++ trunk/Scribus/scribus/ui/pageselector.cpp	Thu May 21 17:39:49 2020
@@ -147,7 +147,7 @@
 
 void PageSelector::setGUIForPage(int i)
 {
-	m_pageCombo->blockSignals(true);
+	bool sigBlocked = m_pageCombo->blockSignals(true);
 	m_pageCombo->setCurrentIndex(i);
 	setCurrentComboItem(m_pageCombo, QString::number(i + 1));
 	m_currentPage = i + 1;
@@ -155,12 +155,12 @@
 	startButton->setEnabled(i != 0);
 	forwardButton->setEnabled(i != m_lastPage - 1);
 	lastButton->setEnabled(i != m_lastPage - 1);
-	m_pageCombo->blockSignals(false);
+	m_pageCombo->blockSignals(sigBlocked);
 }
 
 void PageSelector::setMaximum(int i)
 {
-	m_pageCombo->blockSignals(true);
+	bool sigBlocked = m_pageCombo->blockSignals(true);
 	m_pageCombo->clear();
 	m_lastPage = i;
 	m_validator->setRange(1, m_lastPage);
@@ -170,7 +170,7 @@
 	}
 	setCurrentComboItem(m_pageCombo, QString::number(m_currentPage));
 	pageCountLabel->setText(pageCountString.arg(m_lastPage));
-	m_pageCombo->blockSignals(false);
+	m_pageCombo->blockSignals(sigBlocked);
 }
 
 void PageSelector::goToStart()




More information about the scribus-commit mailing list