r23744 by jghali - Fix coverity 1438492: Dereference before null check

scribus-commit scribus-commit at lists.scribus.net
Sun May 10 16:17:58 UTC 2020


Author: jghali
Date: Sun May 10 16:17:58 2020
New Revision: 23744

URL: http://scribus.net/websvn/listing.php?repname=Scribus&sc=1&rev=23744
Log:
Fix coverity 1438492: Dereference before null check

Modified:
    trunk/Scribus/scribus/ui/smfontfeatures.cpp

Modified: trunk/Scribus/scribus/ui/smfontfeatures.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=23744&path=/trunk/Scribus/scribus/ui/smfontfeatures.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/smfontfeatures.cpp	(original)
+++ trunk/Scribus/scribus/ui/smfontfeatures.cpp	Sun May 10 16:17:58 2020
@@ -472,7 +472,7 @@
 	stylisticSetsButton->setVisible(featureFlags & FontFeatures::StyleSetsMask);
 
 	if (ligaturesGroupBox->isHidden() && capitalsGroupBox->isHidden()
-			&& numeralsGroupBox && stylisticSetsButton->isHidden())
+			&& numeralsGroupBox->isHidden() && stylisticSetsButton->isHidden())
 	{
 		statusLabel->show();
 	}




More information about the scribus-commit mailing list