r23552 by jghali - Make Preflight Verifier less noisy when fill or stroke color is None

scribus-commit scribus-commit at lists.scribus.net
Tue Mar 31 15:03:32 UTC 2020


Author: jghali
Date: Tue Mar 31 15:03:31 2020
New Revision: 23552

URL: http://scribus.net/websvn/listing.php?repname=Scribus&sc=1&rev=23552
Log:
Make Preflight Verifier less noisy when fill or stroke color is None

Modified:
    trunk/Scribus/scribus/documentchecker.cpp

Modified: trunk/Scribus/scribus/documentchecker.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=23552&path=/trunk/Scribus/scribus/documentchecker.cpp
==============================================================================
--- trunk/Scribus/scribus/documentchecker.cpp	(original)
+++ trunk/Scribus/scribus/documentchecker.cpp	Tue Mar 31 15:03:31 2020
@@ -195,8 +195,16 @@
 			itemError.clear();
 			if (((currItem->isAnnotation()) || (currItem->isBookmark)) && (checkerSettings.checkAnnotations))
 				itemError.insert(PDFAnnotField, 0);
-			if ((currItem->hasSoftShadow() || (currItem->fillTransparency() != 0.0) || (currItem->lineTransparency() != 0.0) || (currItem->fillBlendmode() != 0) || (currItem->lineBlendmode() != 0)) && (checkerSettings.checkTransparency))
+			if (currItem->hasSoftShadow() && checkerSettings.checkTransparency)
 				itemError.insert(Transparency, 0);
+			if ((currItem->GrType == 0) && (checkerSettings.checkTransparency))
+			{
+				if (currItem->fillColor() != CommonStrings::None)
+				{
+					if ((currItem->fillTransparency() != 0.0) || (currItem->fillBlendmode() != 0))
+						itemError.insert(Transparency, 0);
+				}
+			}
 			if ((currItem->GrType != 0) && (checkerSettings.checkTransparency))
 			{
 				if (currItem->GrType == 9)
@@ -247,6 +255,14 @@
 							break;
 						}
 					}
+				}
+			}
+			if ((currItem->GrTypeStroke == 0) && (checkerSettings.checkTransparency))
+			{
+				if ((currItem->lineColor() != CommonStrings::None) || !currItem->NamedLStyle.isEmpty())
+				{
+					if ((currItem->lineTransparency() != 0.0) || (currItem->lineBlendmode() != 0))
+						itemError.insert(Transparency, 0);
 				}
 			}
 			if ((currItem->GrTypeStroke != 0) && (checkerSettings.checkTransparency))
@@ -441,7 +457,7 @@
 			if (!(currDoc->layerPrintable(currItem->m_layerID)) && (checkerSettings.ignoreOffLayers))
 				continue;
 			itemError.clear();
-			if (currItem->hasSoftShadow())
+			if (currItem->hasSoftShadow() && checkerSettings.checkTransparency)
 				itemError.insert(Transparency, 0);
 			if ((currItem->GrType == 0) && (checkerSettings.checkTransparency))
 			{




More information about the scribus-commit mailing list