r23324 by jghali - Remove some duplicated code

scribus-commit scribus-commit at lists.scribus.net
Mon Nov 4 09:07:11 UTC 2019


Author: jghali
Date: Mon Nov  4 09:07:11 2019
New Revision: 23324

URL: http://scribus.net/websvn/listing.php?repname=Scribus&sc=1&rev=23324
Log:
Remove some duplicated code

Modified:
    trunk/Scribus/scribus/canvasmode.cpp

Modified: trunk/Scribus/scribus/canvasmode.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=23324&path=/trunk/Scribus/scribus/canvasmode.cpp
==============================================================================
--- trunk/Scribus/scribus/canvasmode.cpp	(original)
+++ trunk/Scribus/scribus/canvasmode.cpp	Mon Nov  4 09:07:11 2019
@@ -597,6 +597,13 @@
 					continue;
 				if (currItem->Parent && !currItem->Parent->groupItemList.contains(currItem))
 					continue;
+
+				QTransform itemTrans = currItem->getTransform(deltax, deltay);
+				double visualWidth = currItem->visualWidth();
+				double visualHeight = currItem->visualHeight();
+				double visualLineWidth = currItem->visualLineWidth();
+				double matRot = getRotationDFromMatrix(itemTrans);
+
 				p->save();
 				if (docSelectionCount < m_canvas->moveWithFullOutlinesThreshold)
 				{
@@ -623,12 +630,6 @@
 					}
 #endif  // GESTURE_FRAME_PREVIEW
 					{
-						QTransform itemTrans = currItem->getTransform(deltax, deltay);
-						double visualWidth = currItem->visualWidth();
-						double visualHeight = currItem->visualHeight();
-						double visualLineWidth = currItem->visualLineWidth();
-						double matRot = getRotationDFromMatrix(itemTrans);
-
 						p->save();
 						p->setBrush(m_brush["outline"]);
 						p->setPen(m_pen["outline"]);
@@ -653,12 +654,6 @@
 				}
 				else
 				{
-					QTransform itemTrans = currItem->getTransform(deltax, deltay);
-					double visualWidth = currItem->visualWidth();
-					double visualHeight = currItem->visualHeight();
-					double visualLineWidth = currItem->visualLineWidth();
-					double matRot = getRotationDFromMatrix(itemTrans);
-
 					p->setBrush(m_brush["outline"]);
 					p->setPen(m_pen["outline"]);
 					p->setWorldTransform(itemTrans, true);




More information about the scribus-commit mailing list