r22874 by jghali - #15583: Clicking "ok" in the preferences calls "Prefs_Scripter::apply()" two times

scribus-commit scribus-commit at lists.scribus.net
Wed Mar 6 00:04:56 UTC 2019


Author: jghali
Date: Wed Mar  6 00:04:56 2019
New Revision: 22874

URL: http://scribus.net/websvn/listing.php?repname=Scribus&sc=1&rev=22874
Log:
#15583: Clicking "ok" in the preferences calls "Prefs_Scripter::apply()" two times

Modified:
    trunk/Scribus/scribus/ui/preferencesdialog.cpp

Modified: trunk/Scribus/scribus/ui/preferencesdialog.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=22874&path=/trunk/Scribus/scribus/ui/preferencesdialog.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/preferencesdialog.cpp	(original)
+++ trunk/Scribus/scribus/ui/preferencesdialog.cpp	Wed Mar  6 00:04:56 2019
@@ -264,7 +264,9 @@
 void PreferencesDialog::accept()
 {
 	saveGuiToPrefs();
-	emit accepted();
+	// #15583: emitting manually accepted should not be needed
+	// QDialog::accept() will emit it by itself
+	// emit accepted();
 	return QDialog::accept();
 }
 




More information about the scribus-commit mailing list