r20815 by jghali -

scribus-commit scribus-commit at lists.scribus.net
Sat Jan 30 22:13:14 UTC 2016


Author: jghali
Date: Sat Jan 30 22:13:14 2016
New Revision: 20815

URL: http://scribus.net/websvn/listing.php?repname=Scribus&sc=1&rev=20815
Log:
coverity #1350542: big parameter passed by value

Modified:
    trunk/Scribus/scribus/mesh.cpp
    trunk/Scribus/scribus/mesh.h

Modified: trunk/Scribus/scribus/mesh.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=20815&path=/trunk/Scribus/scribus/mesh.cpp
==============================================================================
--- trunk/Scribus/scribus/mesh.cpp	(original)
+++ trunk/Scribus/scribus/mesh.cpp	Sat Jan 30 22:13:14 2016
@@ -77,7 +77,7 @@
 	controlColor = gridPoint;
 }
 
-bool meshPoint::operator ==(meshPoint p)
+bool meshPoint::operator ==(const meshPoint& p)
 {
 	return ((gridPoint == p.gridPoint) && (controlTop == p.controlTop) && (controlBottom == p.controlBottom)
 			&& (controlLeft == p.controlLeft) && (controlRight == p.controlRight) &&

Modified: trunk/Scribus/scribus/mesh.h
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=20815&path=/trunk/Scribus/scribus/mesh.h
==============================================================================
--- trunk/Scribus/scribus/mesh.h	(original)
+++ trunk/Scribus/scribus/mesh.h	Sat Jan 30 22:13:14 2016
@@ -38,7 +38,7 @@
 	void moveAbs(double x, double y);
 	void transform(QTransform t);
 	void resetTo(FPoint p);
-	bool operator ==(meshPoint p);
+	bool operator ==(const meshPoint& p);
 	FPoint gridPoint;
 	FPoint controlTop;
 	FPoint controlBottom;




More information about the scribus-commit mailing list