r20995 by craig -

scribus-commit scribus-commit at lists.scribus.net
Fri Feb 12 06:36:16 UTC 2016


Author: craig
Date: Fri Feb 12 06:36:16 2016
New Revision: 20995

URL: http://scribus.net/websvn/listing.php?repname=Scribus&sc=1&rev=20995
Log:
coverity fix a bunch of unchecked dynamic casts in Pageitem undo restore functions

Modified:
    trunk/Scribus/scribus/pageitem.cpp

Modified: trunk/Scribus/scribus/pageitem.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=20995&path=/trunk/Scribus/scribus/pageitem.cpp
==============================================================================
--- trunk/Scribus/scribus/pageitem.cpp	(original)
+++ trunk/Scribus/scribus/pageitem.cpp	Fri Feb 12 06:36:16 2016
@@ -6056,7 +6056,7 @@
 void PageItem::restoreArc(SimpleState *state, bool isUndo)
 {
 	ScItemState<QPair<FPointArray, FPointArray> > *ss = dynamic_cast<ScItemState<QPair<FPointArray, FPointArray> > *>(state);
-	if (!is)
+	if (!ss)
 		qFatal("PageItem::restoreArc: dynamic cast failed");
 	PageItem_Arc *item = asArc();
 	if (isUndo)




More information about the scribus-commit mailing list