r20987 by jghali -

scribus-commit scribus-commit at lists.scribus.net
Thu Feb 11 23:26:52 UTC 2016


Author: jghali
Date: Thu Feb 11 23:26:52 2016
New Revision: 20987

URL: http://scribus.net/websvn/listing.php?repname=Scribus&sc=1&rev=20987
Log:
fix coverity #1352149: dereference after null check

Modified:
    trunk/Scribus/scribus/ui/smpstylewidget.cpp

Modified: trunk/Scribus/scribus/ui/smpstylewidget.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=20987&path=/trunk/Scribus/scribus/ui/smpstylewidget.cpp
==============================================================================
--- trunk/Scribus/scribus/ui/smpstylewidget.cpp	(original)
+++ trunk/Scribus/scribus/ui/smpstylewidget.cpp	Thu Feb 11 23:26:52 2016
@@ -1308,7 +1308,9 @@
 
 void SMPStyleWidget::handleUpdateRequest(int updateFlags)
 {
-	if ((updateFlags & reqColorsUpdate) && m_Doc)
+	if (!m_Doc)
+		return;
+	if (updateFlags & reqColorsUpdate)
 		fillColorCombo(m_Doc->PageColors);
 	if (updateFlags & reqNumUpdate)
 		fillNumerationsCombo();




More information about the scribus-commit mailing list