r18492 by craig - #11504: Also check for empty text frames in a chain, and also check master page items

scribus-commit scribus-commit at lists.scribus.net
Mon Sep 23 21:29:54 UTC 2013


Author: craig
Date: Mon Sep 23 21:29:54 2013
New Revision: 18492

URL: http://scribus.net/websvn/listing.php?repname=Scribus&sc=1&rev=18492
Log:
#11504: Also check for empty text frames in a chain, and also check master page items

Modified:
    trunk/Scribus/scribus/documentchecker.cpp

Modified: trunk/Scribus/scribus/documentchecker.cpp
URL: http://scribus.net/websvn/diff.php?repname=Scribus&rev=18492&path=/trunk/Scribus/scribus/documentchecker.cpp
==============================================================================
--- trunk/Scribus/scribus/documentchecker.cpp (original)
+++ trunk/Scribus/scribus/documentchecker.cpp Mon Sep 23 21:29:54 2013
@@ -364,6 +364,9 @@
 				if ( currItem->frameOverflows() && (checkerSettings.checkOverflow) && (!((currItem->isAnnotation()) && ((currItem->annotation().Type() == Annotation::Combobox) || (currItem->annotation().Type() == Annotation::Listbox)))))
 					itemError.insert(TextOverflow, 0);
 
+				if (checkerSettings.checkEmptyTextFrames && (currItem->itemText.length()==0 || currItem->frameUnderflows()))
+					itemError.insert(EmptyTextFrame, 0);
+
 				if (currItem->isAnnotation())
 				{
 					ScFace::FontFormat fformat = currItem->itemText.defaultStyle().charStyle().font().format();
@@ -656,7 +659,7 @@
 				if ( currItem->frameOverflows() && (checkerSettings.checkOverflow) && (!((currItem->isAnnotation()) && ((currItem->annotation().Type() == Annotation::Combobox) || (currItem->annotation().Type() == Annotation::Listbox)))))
 					itemError.insert(TextOverflow, 0);
 
-				if (checkerSettings.checkEmptyTextFrames && currItem->itemText.length()==0)
+				if (checkerSettings.checkEmptyTextFrames && (currItem->itemText.length()==0 || currItem->frameUnderflows()))
 					itemError.insert(EmptyTextFrame, 0);
 
 				if (currItem->isAnnotation())




More information about the scribus-commit mailing list