r14092 by jghali - #8375 : better error messages for Render Frames (patch from Herm)

scribus-commit scribus-commit at lists.scribus.net
Mon Oct 5 01:45:14 CEST 2009


Revision: 14092
Author: jghali
Date: 2009-10-04T23:46:07.362510Z
Commit message: #8375 : better error messages for Render Frames (patch from Herm)

Changeset: 
M  /branches/Version135/Scribus/scribus/pageitem_latexframe.cpp

Diffs:
Index: scribus/pageitem_latexframe.cpp
===================================================================
--- scribus/pageitem_latexframe.cpp	(revision 14091)
+++ scribus/pageitem_latexframe.cpp	(revision 14092)
@@ -158,9 +158,24 @@
 		imgValid = false;
 		if (firstWarning && !killed)
 		{
-			QMessageBox::critical(0, tr("Error"), "<qt>" + 
-				tr("Running the external application failed!")
-				+ "</qt>", 1, 0, 0);
+			bool editorRunning = internalEditor && internalEditor->isVisible();
+			QMessageBox msgBox;
+			msgBox.setText(tr("Running the external application failed!"));
+			QString informativeText = tr("This is usually a problem with your input. Please check the program's output.");
+			if (!editorRunning) {
+				informativeText += " "+tr("Do you want to open the editor to fix the problem?");
+				msgBox.setStandardButtons(QMessageBox::Yes|QMessageBox::No);
+				msgBox.setDefaultButton(QMessageBox::Yes);
+			} else {
+				msgBox.setStandardButtons(QMessageBox::Ok);
+				msgBox.setDefaultButton(QMessageBox::Ok);
+			}
+			msgBox.setIcon(QMessageBox::Warning);
+			msgBox.setInformativeText(informativeText);
+			msgBox.setDetailedText(output());
+			if ((msgBox.exec() == QMessageBox::Yes) && !editorRunning) {
+				runEditor();
+			}
 			firstWarning = false;
 		}
 		qCritical() << "RENDER FRAME: updateImage():" << tr("Running the external application failed!");
@@ -401,7 +416,7 @@
 	{
 		if (latex->error() == QProcess::FailedToStart) {
 			QMessageBox::critical(0, tr("Error"), "<qt>" +
-								  tr("The application \"%1\" failed to start!").
+								  tr("The application \"%1\" failed to start! Please check the path: ").
 								  arg(config->executable())
 								  + "</qt>", 1, 0, 0);
 		} else {
@@ -575,3 +590,4 @@
 	return htmlText;
 }
 
+




More information about the scribus-commit mailing list