r13872 by jghali - #8347, code change recommended by Novell audit of 1.3.3.12 : bad call to C++ STL erase

scribus-commit scribus-commit at lists.scribus.net
Wed Aug 26 05:42:01 CEST 2009


Revision: 13872
Author: jghali
Date: 2009-08-16T11:46:51.871366Z
Commit message: #8347, code change recommended by Novell audit of 1.3.3.12 : bad call to C++ STL erase

Changeset: 
M  /branches/Version133x/Scribus/scribus/undomanager.cpp

Diffs:
Index: scribus/undomanager.cpp
===================================================================
--- scribus/undomanager.cpp	(revision 13871)
+++ scribus/undomanager.cpp	(revision 13872)
@@ -286,9 +286,13 @@
 void UndoManager::removeGui(UndoGui* gui)
 {
 	std::vector<UndoGui*>::iterator it;
-	for (it = undoGuis.begin(); it != undoGuis.end(); ++it)
+	for (it = undoGuis.begin(); it != undoGuis.end();)
+	{
 		if (*it == gui)
-			undoGuis.erase(it);
+			it = undoGuis.erase(it);
+		else
+			++it;
+	}
 }
 
 void UndoManager::switchStack(const QString& stackName)




More information about the scribus-commit mailing list